Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ninjutsu must be able to activate only on/after declare blockers step #13454

Open
JayDi85 opened this issue Mar 15, 2025 · 1 comment
Open

Ninjutsu must be able to activate only on/after declare blockers step #13454

JayDi85 opened this issue Mar 15, 2025 · 1 comment
Labels
bug Bugs and errors

Comments

@JayDi85
Copy link
Member

JayDi85 commented Mar 15, 2025

Bug report from #5859:

Ninjutsu wrong combat step - I can activate Ninjutsu before blockers are declared.

Oracle:

The ninjutsu ability can be activated only after blockers have been declared. Before then, attacking creatures are neither blocked nor unblocked.
(2022-02-18)
The ninjutsu ability can be activated during the declare blockers step, combat damage step, or end of combat step. In most cases (see below), if you wait until the combatdamage step or end of combat step, it will be after combat damage has been dealt, so the Ninja won't deal combat damage.
(2022-02-18)

If confirmed then potential fix: canPay method of the ability — check that current step index >= declare blocker step index.

Image

@JayDi85 JayDi85 added the bug Bugs and errors label Mar 15, 2025
@xenohedron
Copy link
Contributor

Is this not covered correctly by UnblockedPredicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors
Projects
None yet
Development

No branches or pull requests

2 participants