Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subdivisions #9

Open
fkrauthan opened this issue May 29, 2023 · 3 comments · May be fixed by #16
Open

Support subdivisions #9

fkrauthan opened this issue May 29, 2023 · 3 comments · May be fixed by #16
Assignees
@AD4MANTIS
Labels
enhancement New feature or request

Comments

@fkrauthan
Copy link

It seems like python-holidays supports country subdivisions (as every countries subdivision/province often have their own holidays). I couldn't find that API exposed here? Can this be added?
@yukinarit yukinarit added the enhancement New feature or request label May 9, 2024
@yukinarit
Copy link
Member

Hi @fkrauthan Sorry for the delay 🙏
if you're still interested, I can take a look.

@fkrauthan
Copy link
Author

Don't really have a use-cases at the moment for this anymore (I switched to an API approach) but overall probably would still be a good addition to this library.

@AD4MANTIS
Copy link
Contributor

I implemented subdivisions here: AD4MANTIS#1
After #11 is done I will create a PR to this repo.

@AD4MANTIS AD4MANTIS linked a pull request Jun 12, 2024 that will close this issue
Open
1 task
@yukinarit yukinarit linked a pull request Aug 2, 2024 that will close this issue
Implemented subdivisions for US & DE #16
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AD4MANTIS AD4MANTIS

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented subdivisions for US & DE AD4MANTIS/holidays-rs
3 participants
@fkrauthan @yukinarit @AD4MANTIS