Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overriding energy parameter dirs via env vars #5

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

marcom
Copy link
Owner

@marcom marcom commented Jan 18, 2024

Always ensure the DATAPATH, CYCLEFOLD_DATAPATH env vars are pointing to the correct path from the RNAstructure_jll binary package.

These paths can be overridden with the RNASTRUCTURE_JL_DATAPATH, RNASTRUCTURE_JL_CYCLEFOLD_DATAPATH env vars if necessary.

Don't warn if the DATAPATH, CYCLEFOLD_DATAPATH env vars are already set to the correct directories. This avoids unnecessary warnings when running the tests.

Also add tests to ensure this is working correctly.

Fixes #4.

Always ensure the DATAPATH, CYCLEFOLD_DATAPATH env vars are pointing
to the correct path from the `RNAstructure_jll` binary package.

These paths can be overridden with the RNASTRUCTURE_JL_DATAPATH,
RNASTRUCTURE_JLCYCLEFOLD_DATAPATH env vars if necessary.

Don't warn if the DATAPATH, CYCLEFOLD_DATAPATH env vars are already
set to the correct directories.  This avoids unnecessary warnings when
running the tests.

Fixes #4.
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@marcom marcom merged commit fa6d7e3 into main Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handle env vars DATAPATH, CYCLEFOLD_DATAPATH if already set correctly or when overriding
2 participants