-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move feedback to app header, add mailing list link to home page #4241
base: develop
Are you sure you want to change the base?
Conversation
@kgodey @zackkrida I'd like to understand more about how you envision importance given to the feedback option in the product and where or not we should have a single feedback option or separate usecase and general feedback options. @ghislaineguerin I'd like to discuss the overall UX in placing the feedback in the product and de-cluttering the home page. |
@pavish this is great! Some notes:
As for the use case feedback prominence, I think I'll have to defer to @kgodey there. To me, that should really be part of the onboarding flow where apps commonly ask questions "how big is your company, what competitors do you use, etc." so I'm not sure about where exactly it should be in the interface. |
Thanks @pavish here are my questions:
![]() ![]()
|
I agree. I would first like to come to an agreement if placing the feedback button on the app header is good, or if we should experiment placing it elsewhere on the product. I looks like both of you are good with the location and mostly concerned on the visual aspects of it, which we can tweak. Let me know if that's not the case.
No. The idea is that it would always the present.
Yes, that's what I think we should have too. We would only have a general feedback functionality in the location specified in the screenshot. The purpose of this PR was to open up a discussion and I just placed the existing component up there. @kgodey has expressed opinions that we need two kinds of feedback. A separate use case feedback option somewhere in the product and a general feedback one, and that the use case feedback option should be more prominent. First, I'd like to come to a decision if we need them to be separate. Second, if yes, I'd like to figure out how and where we'd place both, and how to let the user clearly understand the difference between them. |
@pavish I don't think they should be separate, we should figure out how to ask the user a follow up question once they provide feedback. |
To try and summarize a bit, I think the questions for @kgodey are:
|
I don't think we necessarily need to do this. I think @ghislaineguerin's idea of asking a follow up question would work. I just don't think it should be the same feedback form as submitting general feedback. We can also replace it with a link to the survey if we update the survey to include a freeform field about the use case (which we should do anyway)
Yes, I like this, it's prominent.
Skipping this since it was answered above. |
Hi @pavish, just an update on how to proceed here:
|
@pavish I have created the wireframes for the two different options discussed today: @zackkrida I think option 2 is close to what you are describing above. |
@ghislaineguerin, yes, Option 2 looks perfect for what I was thinking! Concerning the designs: I assume we would omit the checkbox about contacting users and the dropdown for types of feedback in this version? Perhaps the dropdown is simple enough to implement, assuming we know what types of feedback we want to support, but what would the email checkbox even do? We don't have email addresses for every user so I'm uncertain how it would work. |
Yes, we wouldn't do it for this version. The plan was to see possible ways we can use/improve the feedback section.
The idea was that the email checkbox would show a text field when checked where the user would specify their email. That way we capture the email information with the feedback. That text field is missing in the design. |
@ghislaineguerin Option 2 looks great and it looks like @zackkrida is agreement. I am going to place the content in the dropdown when the button is clicked instead of a modal. As mentioned above, I think we can omit the select feedback type dropdown for now. We can implement it iteratively if required. |
@zackkrida @ghislaineguerin I've simplified the UX and updated the PR description with the screenshots. I've not included the call team option, I'm not sure if it's something we want to do now and if we have a public call scheduling link. @zackkrida Let me know if we have a link that I can add. @zackkrida & @ghislaineguerin: Please review the UX and the flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pavish. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @pavish.
I haven't actually looked at the submitted feedback to verify that it ends up in our hands. I'll try to spend some time on that maybe today if I can. But I'm skipping that for now because it doesn't seem relevant to this PR.
I pushed a few additional commits. I'll leave this PR for you to merge, assuming you're satisfied with these changes I've added.
These should be straightforward:
I also pushed 521b6a9 which I'd like you to look over. Before this commit, this nav header felt a bit too squished when viewing some pages on narrow viewports. This commit improves the logic used to simplify elements in the nav header. We had previously been applying this sort of logic to the "Shortcuts" menu when that menu was placed in the nav header where the "Feedback" item is now. Here's a quick video which demonstrates the problem and my changes to fix it:
2025-02-14_09-26-35.mp4
I'm assigning this back to you, @pavish so that you can look over these changes and merge.
Really nice work @pavish! |
Fixes #4096
Fixes #4228
Fixes #4233
Feedback dropdown
Resources section - mailing list
Note to reviewers:
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin