Adding system tests #399
Merged
Adding system tests #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete unnecessary tests * Move some tests into 'systemTests' folder
sameagen-MW
reviewed
Jan 24, 2025
src/test/java/com/mathworks/ci/systemTests/RunMatlabBuildIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemTests/RunMatlabBuildIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemTests/RunMatlabBuildIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemTests/StartupOptionsIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemTests/UseMATLABVersionIT.java
Outdated
Show resolved
Hide resolved
mw-kapilg
reviewed
Feb 5, 2025
davidbuzinski
approved these changes
Feb 6, 2025
sameagen-MW
approved these changes
Feb 6, 2025
| public void verifyGlobalToolScriptedPipeline() throws Exception { | ||
| Utilities.setMatlabInstallation("MATLAB_PATH_1", Utilities.getMatlabRoot(), jenkins); | ||
| String script = "node {\n" + | ||
| " def matlabver\n" + |
There was a problem hiding this comment.
Do we need this definition here?
There was a problem hiding this comment.
If you are talking about 'setMATLABInstallation' this is equivalent to defining MATLAB as global tool. As in the test we are using "matlab 'MATLAB_PATH_1'", we need to define the tool first.
| // 'test' task fails | ||
| jenkins.assertBuildStatus(Result.FAILURE, build); | ||
| jenkins.assertLogContains("buildtool check test dummy", build); | ||
| jenkins.assertLogNotContains("In check task", build); |
There was a problem hiding this comment.
I'm somewhat curious why the log shouldn't contain the output from the check task?
There was a problem hiding this comment.
The test data is set so that the 'test' task fails(as source folder is not added to path). This is so that we have a task that fails which can used in testing different scenarios
src/test/java/com/mathworks/ci/systemtests/UseMATLABVersionIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mathworks/ci/systemtests/StartupOptionsIT.java
Outdated
Show resolved
Hide resolved
mw-kapilg
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has following changes:
System tests needs access to MATLAB to run successfully. The MATLAB root path is read from 'MATLAB_ROOT' env variable. These tests are configured to run only if the 'MATLAB_ROOT' variable is defined. This is to ensure that the tests pass in Jenkinsci jobs and it makes it easier to run the tests locally as well.
Matrix project needs two versions of MATLAB to run successfully. Since there is an error while using Set up MATLAB twice, these tests would be skipped(Updating the main.yml to define MATLAB_ROOT_22b would trigger the tests)
System tests follow the standard integration tests format *IT.java. These tests can be run in isolation using failsafe plugin.
mvn test - Runs only unit tests
mvn verify - Runs both unit and system tests
mvn failsafe:integration-test - Runs only system tests