Resolves the error which occurs when calling setup-matlab twice in single workflow #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vahila
changed the title
mcafaro
reviewed
Feb 13, 2025
src/mpm.ts
Outdated
| @@ -37,15 +38,21 @@ export async function setup(platform: string, architecture: string): Promise<str | |||
| return Promise.reject(Error("Unable to find runner temporary directory.")); | |||
| } | |||
| let mpmDest = path.join(runner_temp, `mpm${ext}`); | |||
| let mpm: string = await tc.downloadTool(mpmUrl, mpmDest); | |||
| if (!fs.existsSync(mpmDest)){ | |||
There was a problem hiding this comment.
If MPM already exists on the system, it might be better to delete it and redownload rather than skip downloading. I'm just thinking about self-hosted runners where they may have downloaded MPM a long time ago and its now a very out-of-date version.
There was a problem hiding this comment.
Makes sense. I updated the logic to delete the MPM file. Incidentally it also resolves the macos-14, R2023a job failure as well.
mcafaro
approved these changes
Feb 18, 2025
davidbuzinski
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is occurring when mpm was getting downloaded in second setup-matlab call as the file already exists.
Current fix is to check if mpm file exists before downloading it.