From 8a9f57633d1cb32e0ef7670c3b796a5708ce318b Mon Sep 17 00:00:00 2001 From: Altamash Shaikh Date: Fri, 9 Feb 2024 08:44:39 +0530 Subject: [PATCH 1/2] Improved debug url check, #AS-292 --- javascripts/tagmanagerHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascripts/tagmanagerHelper.js b/javascripts/tagmanagerHelper.js index 632f1300f..776acf7b5 100644 --- a/javascripts/tagmanagerHelper.js +++ b/javascripts/tagmanagerHelper.js @@ -266,7 +266,7 @@ ajaxRequest.send(); }; tagManagerHelper.updateDebugSiteFlag = function (url, idContainer, debugFlag) { - if (!url || !idContainer || !debugFlag) { + if (!url || !idContainer || !debugFlag || url.indexOf('http') !== 0 || url.indexOf('://') < 4) { return; } window.open(url + (url.indexOf('?') == -1 ? '?' : '&') + 'mtmPreviewMode=' + encodeURIComponent(idContainer) + '&mtmSetDebugFlag=' + encodeURIComponent(debugFlag), '_blank', 'noreferrer'); From fb78d9a41dfb34285cc172295826d61e5d486993 Mon Sep 17 00:00:00 2001 From: Altamash Shaikh Date: Mon, 12 Feb 2024 06:55:51 +0530 Subject: [PATCH 2/2] Simplified condition via regex --- javascripts/tagmanagerHelper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascripts/tagmanagerHelper.js b/javascripts/tagmanagerHelper.js index 776acf7b5..81c4faef7 100644 --- a/javascripts/tagmanagerHelper.js +++ b/javascripts/tagmanagerHelper.js @@ -266,7 +266,7 @@ ajaxRequest.send(); }; tagManagerHelper.updateDebugSiteFlag = function (url, idContainer, debugFlag) { - if (!url || !idContainer || !debugFlag || url.indexOf('http') !== 0 || url.indexOf('://') < 4) { + if (!url || !idContainer || !debugFlag || !(/^https?:\/\//.test(url))) { return; } window.open(url + (url.indexOf('?') == -1 ? '?' : '&') + 'mtmPreviewMode=' + encodeURIComponent(idContainer) + '&mtmSetDebugFlag=' + encodeURIComponent(debugFlag), '_blank', 'noreferrer');