Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IrcConnection type should inherit from net.Socket #107

Open
aabluedragon opened this issue May 28, 2023 · 0 comments
Open

IrcConnection type should inherit from net.Socket #107

aabluedragon opened this issue May 28, 2023 · 0 comments

Comments

@aabluedragon
Copy link

aabluedragon commented May 28, 2023

Latest commits to master expose only a few properties in IrcConnection, even though the value in ircClient.conn actually refers to a subtype of net.Socket.
As a result, this is causing issues because many important properties/functions are no longer available in ircClient.conn, such as destroyed, and the write function only accepts string instead of also the Buffer type.
To work around this issue temporary, I replaced these 2 type declarations:

import { Socket } from 'net';
.
.
.
export type IrcConnectionEventEmitter = Socket;
export interface IrcConnection extends IrcConnectionEventEmitter {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant