Fix .data property in IsomorphicBaseEvent
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the .data property is properly set when using createIsomorphicEventData
Set the .data property again (even though it's already defined in the base class). This is related to this issue: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier It seems to be that things are running fine when compiling, but if running in jest or ts-node, the behavior described in useDefineForClassFields will be used instead. This will cause the specialization of the data property to a sub-type in IsomorphicBaseEvent to actually re-declare the property as undefined. Closes #50
ThaNarie
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
.dataproperty again (even though it's already defined in the base class). This is related to this issue the new declaration behavior for class fields.It seems to be that things are running fine when compiling, but if running in jest or ts-node, the behavior described in
useDefineForClassFieldswill be used instead. This will causethe specialization of the data property to a sub-type in
IsomorphicBaseEventto actually re-declare the property asundefined.Note: we could use the
declarekeyword here as well, but that would require a typescript update to 3.7. This seems to be the most straightforward solutionCloses #50