Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration parameters for OAuth2 token URLs incorrectly named issuer URLs #54

Open
holger-stenzhorn opened this issue Jan 14, 2025 · 2 comments · Fixed by #55
Open
Assignees
Labels
bug Something isn't working ready for release
Milestone

Comments

@holger-stenzhorn
Copy link

The parameters to configure OAuth2 token URLs are incorrectly named issuer URLs in mii-process-data-sharing, mii-process-data-transfer and mii-process-report, i.e.

  • DE_MEDIZININFORMATIK_INITIATIVE_DATA_SHARING_DIC_FHIR_SERVER_OAUTH2_ISSUER_URL (de.medizininformatik.initiative.data.sharing.dic.fhir.server.oauth2.issuer.url)
  • DE_MEDIZININFORMATIK_INITIATIVE_DATA_SHARING_DMS_FHIR_SERVER_OAUTH2_ISSUER_URL (de.medizininformatik.initiative.data.sharing.dms.fhir.server.oauth2.issuer.url)
  • DE_MEDIZININFORMATIK_INITIATIVE_DATA_TRANSFER_DIC_FHIR_SERVER_OAUTH2_ISSUER_URL (de.medizininformatik.initiative.data.transfer.dic.fhir.server.oauth2.issuer.url)
  • DE_MEDIZININFORMATIK_INITIATIVE_DATA_TRANSFER_DMS_FHIR_SERVER_OAUTH2_ISSUER_URL (de.medizininformatik.initiative.data.transfer.dms.fhir.server.oauth2.issuer.url)
  • DE_MEDIZININFORMATIK_INITIATIVE_REPORT_DIC_FHIR_SERVER_OAUTH2_ISSUER_URL (de.medizininformatik.initiative.report.dic.fhir.server.oauth2.issuer.url)

This is even more problematic as the respective parameter in mii-process-feasibility correctly sets the issuer URL (and not the token URL), i.e. DE_MEDIZININFORMATIK_INITIATIVE_FEASIBILITY_DSF_PROCESS_CLIENT_STORE_AUTH_OAUTH_ISSUER_URL (de.medizininformatik_initiative.feasibility_dsf_process.client.store.auth.oauth.issuer.url)

The two solutions could be either:

  1. Rename the parameters to ..._OAUTH2_TOKEN_URL (...oauth2.token.url)
  2. Handle the parameters really as issuer URLs and not as token URLs
@wetret
Copy link
Member

wetret commented Jan 15, 2025

Solution 2 should be preferred to be consistent with the feasibility process.

@wetret
Copy link
Member

wetret commented Jan 15, 2025

@wetret wetret self-assigned this Jan 15, 2025
@wetret wetret added documentation Improvements or additions to documentation bug Something isn't working and removed documentation Improvements or additions to documentation labels Jan 15, 2025
@wetret wetret added this to the v1.1.3.0 milestone Jan 15, 2025
@wetret wetret linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants