-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should pip install recOrder-napari
install napari
?
#498
Comments
How would this be implemented? IIRC optional dependencies can only add dependencies, not remove them. Edit: see this discussion on python discourse. |
I'm actually fine with installing napari by default since it's at least pure python, but currently |
Given the limitations of python, the best I can think of is what napari does (or had to do): using a |
Thanks for helping us think this through, @ziw-liu. So I think we're heading towards: (Novice users, recommended in docs): |
@mattersoflight suggested that we change
recOrder
's dependencies so thatpip install recOrder-napari
installsnapari
. I agree that, if possible,pip install recOrder-napari
should provide the most polished installation path.In chatting with @ziw-liu and @edyoshikun (cc @amitabhverma) about this plan, they brought up two potential issues:
PySide
orPyQt
recOrder-napari
withoutnapari
so that they can use it with existing environments.@ziw-liu @edyoshikun would the following solution work? If not, can you share your preferred installation instructions for both novices and experienced users.
(Novice users):
pip install recOrder-napari
installsnapari[pyqt6]
Experienced users):
pip install recOrder-napari[no-napari]
does not installnapari
so thatrecOrder
can be used via CLI and/or integrated into other environments.The text was updated successfully, but these errors were encountered: