Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check plugin can be installed by its pip_url in PR checks #1191

Closed
ReubenFrankel opened this issue Mar 8, 2023 · 2 comments
Closed

ci: check plugin can be installed by its pip_url in PR checks #1191

ReubenFrankel opened this issue Mar 8, 2023 · 2 comments
Assignees
@pnadolny13

Comments

@ReubenFrankel
Copy link
Contributor

From #1189:

In the future, it would be nice to have a CI check here that attempts to pip install from the supplied pip_url to catch potential meltano install issues.
@aaronsteers
Copy link
Contributor

Agreed. And thanks for logging.

Related:

@ReubenFrankel ReubenFrankel mentioned this issue Sep 5, 2023
Merged
@ReubenFrankel
Copy link
Contributor Author

Closing this since #1727 was merged a while back: https://github.com/meltano/hub/actions/workflows/test_meltano_add_install.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnadolny13 pnadolny13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaronsteers @pnadolny13 @ReubenFrankel