Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the tcpcheck is always false in meshsync #586

Open
jxs1211 opened this issue Jan 21, 2025 · 2 comments · May be fixed by #587
Open

the tcpcheck is always false in meshsync #586

jxs1211 opened this issue Jan 21, 2025 · 2 comments · May be fixed by #587
Labels
kind/bug Something isn't working

Comments

@jxs1211
Copy link

jxs1211 commented Jan 21, 2025

Current Behavior

  1. when meshsync controller is checking the broker's service endpoint, the tcpcheck for external endpoint always return false, which make the tcp connection check can't be executed essentially
  2. if the endpoint external address is localhost, the TcpCheck will always be executed.

Expected Behavior

  1. the external endpoint will be checked successfully
  2. the TcpCheck is not necessary to be executed if the external address is localhost

Screenshots/Logs

	// If external endpoint not reachable
	if !utils.TcpCheck(endpoint.External, &utils.MockOptions{}) && endpoint.External.Address != "localhost" {
		newUrl, err = neturl.Parse(url)
		if err != nil {
			return nil
		}

Environment

  • Host OS: Mac
  • Platform: Kubernetes
  • Meshery Server Version: n/a
  • Meshery Client Version: n/a

Contributor Guides and Resources

@jxs1211 jxs1211 added the kind/bug Something isn't working label Jan 21, 2025
Copy link

welcome bot commented Jan 21, 2025

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@jxs1211 jxs1211 linked a pull request Jan 21, 2025 that will close this issue
@jxs1211
Copy link
Author

jxs1211 commented Jan 21, 2025

@leecalcote I think it's an issue, and I filed a pr for it, pls take a look.

@jxs1211 jxs1211 closed this as completed Jan 21, 2025
@jxs1211 jxs1211 reopened this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant