Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pip to uv #747

Closed
terrytangyuan opened this issue Jan 13, 2025 · 2 comments
Closed

Switch from pip to uv #747

terrytangyuan opened this issue Jan 13, 2025 · 2 comments
Assignees

Comments

@terrytangyuan
Copy link
Collaborator

🚀 Describe the new functionality needed

uv has great performance boost https://github.com/astral-sh/uv

A couple of projects started adopting it, e.g. vLLM: https://blog.vllm.ai/2025/01/10/dev-experience.html

💡 Why is this needed? What if we don't build it?

Performance improvement

Other thoughts

No response

@ashwinb
Copy link
Contributor

ashwinb commented Jan 14, 2025

yesss! we would really like to get on to uv and will likely prioritize this soon

@ashwinb ashwinb added this to the v0.1 milestone Jan 14, 2025
@ashwinb ashwinb self-assigned this Jan 14, 2025
@ashwinb ashwinb changed the title Switch from pip to nv Switch from pip to uv Jan 14, 2025
@hardikjshah hardikjshah removed this from the v0.1 milestone Jan 16, 2025
ashwinb added a commit that referenced this issue Feb 1, 2025
## What does this PR do? 

See issue: #747 -- `uv` is just plain better. This PR does the bare
minimum of replacing `pip install` by `uv pip install` and ensuring `uv`
exists in the environment.

## Test Plan 

First: create new conda, `uv pip install -e .` on `llama-stack` -- all
is good.
Next: run `llama stack build --template together` followed by `llama
stack run together` -- all good
Next: run `llama stack build --template together --image-name yoyo`
followed by `llama stack run together --image-name yoyo` -- all good
Next: fresh conda and `uv pip install -e .` and `llama stack build
--template together --image-type venv` -- all good.

Docker: `llama stack build --template together --image-type container`
works!
@terrytangyuan
Copy link
Collaborator Author

Closed via #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants