No support for Terminos for Window PC #826
Comments
6 tasks
ashwinb
pushed a commit
that referenced
this issue
Jan 28, 2025
# What does this PR do? This PR implements windows platform support for build_container.sh execution from terminal. Additionally, it resolves "no support for Terminos and PTY for Window PC" issues. - [x] Addresses issue (#issue) Releates issues: #826, #726 ## Test Plan Changes were tested manually by executing standard scripts from LLama guide: - llama stack build --template ollama --image-type container - llama stack build --list-templates - llama stack build ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Ran pre-commit to handle lint / formatting issues. - [x] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
|
This has been fixed via #889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System Info
Window 11- Python 3.11
Information
🐛 Describe the bug
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\lib\tty.py", line 5, in
from termios import *
ModuleNotFoundError: No module named 'termios'
Error logs
PS D:\chandan\rnd\llm> llama model list
Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 196, in _run_module_as_main
return run_code(code, main_globals, None,
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "D:\deecogs\rnd\llm\llama_env\Scripts\llama.exe_main.py", line 4, in
from llama_stack.cli.llama import main
File "D:\deecogs\rnd\llm\llama_env\lib\site-packages\llama_stack_init.py", line 7, in
from llama_stack.distribution.library_client import ( # noqa: F401
File "D:\deecogs\rnd\llm\llama_env\lib\site-packages\llama_stack\distribution\library_client.py", line 34, in
from llama_stack.distribution.build import print_pip_install_help
File "D:\deecogs\rnd\llm\llama_env\lib\site-packages\llama_stack\distribution\build.py", line 15, in
from llama_stack.distribution.utils.exec import run_with_pty
File "D:\deecogs\rnd\llm\llama_env\lib\site-packages\llama_stack\distribution\utils\exec.py", line 10, in
import pty
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\lib\pty.py", line 12, in
import tty
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\lib\tty.py", line 5, in
from termios import *
ModuleNotFoundError: No module named 'termios'
Expected behavior
Run in Window
The text was updated successfully, but these errors were encountered: