Revert "Fix llama stack build docker creation to have correct entrypoint #872
+6
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int" This reverts commit a8345f5.
terrytangyuan
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic and
sixianyi0721
as code owners
facebook-github-bot
added
the
CLA Signed
|
This is not the correct fix even though it fixes the issue. The offending commit was landed because it fixed docker running when you built the docker for templates (--template fireworks, e.g.) We need to maintain that fix and fix the regression caused when passing a config file as an argument with the --template parameter. Closing this revert PR and I will forward fix this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a8345f5.
Fixes #870.