-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With new release automation, container images workflow is no longer trigged by tag creation #772
Comments
Ping @mquhuy |
/triage accepted |
/kind bug |
/reopen |
@tuminoid: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @mquhuy |
It has example and states that it must use another step to upload an artifact with wanted data, and then the new workflow must load it. This issue is mentioned in the description. So, we might want to consider adding the image build directly into release workflow as then it can use inputs directly (with the price of some duplication in image building code), or add the artifact upload/download to the image build, to pass the ref information. |
After #734 was merged, release tags are created by this workflow. This means build-images-action is no longer triggering by tag creation, due Github side security precaution to avoid loops.
We need to fix it. Some ideas:
workflow_run
- change the triggering mechanism, issue is how the tag data is passedworkflow_dispatch
- maybe we change both a bit souses:
can be integrated as part of releaseIt does not seem that adding more permissions like
actions: write
etc helps.The text was updated successfully, but these errors were encountered: