Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With new release automation, container images workflow is no longer trigged by tag creation #772

Closed
tuminoid opened this issue Dec 2, 2024 · 7 comments · Fixed by #775 or #840
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Dec 2, 2024

After #734 was merged, release tags are created by this workflow. This means build-images-action is no longer triggering by tag creation, due Github side security precaution to avoid loops.

We need to fix it. Some ideas:

  • workflow_run - change the triggering mechanism, issue is how the tag data is passed
  • workflow_dispatch - maybe we change both a bit so uses: can be integrated as part of release

It does not seem that adding more permissions like actions: write etc helps.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Dec 2, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Dec 2, 2024

Ping @mquhuy

@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted
/kind feature

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/kind bug

@metal3-io-bot metal3-io-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2024
@Rozzii Rozzii removed the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2024
@tuminoid
Copy link
Member Author

/reopen

@metal3-io-bot metal3-io-bot reopened this Dec 18, 2024
@metal3-io-bot
Copy link
Contributor

@tuminoid: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/assign @mquhuy

@tuminoid
Copy link
Member Author

workflow_run cannot use the data from triggering workflow by any dot syntax, see this Github documentation

It has example and states that it must use another step to upload an artifact with wanted data, and then the new workflow must load it. This issue is mentioned in the description. workflow_run is limited versus workflow_dispatch (more commony used) due security restrictions (dispatch actively calls a workflow, while run just self-triggers on another jobs).

So, we might want to consider adding the image build directly into release workflow as then it can use inputs directly (with the price of some duplication in image building code), or add the artifact upload/download to the image build, to pass the ref information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
4 participants