Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if errorprone metric loading is still a thing #158

Open
bmario opened this issue May 23, 2022 · 1 comment
Open

Check if errorprone metric loading is still a thing #158

bmario opened this issue May 23, 2022 · 1 comment
Labels
refactor Code that needs to be refactored, i.e. outsource or rewrite

Comments

@bmario
Copy link
Member

bmario commented May 23, 2022

In https://github.com/metricq/metricq-webview/blob/master/src/MetricHandler.js#L53 and #154 I stumbled upon the error-prone metric loading. It complicates the code and after a quick search, I'm not sure, if this is still in use.
@bmario bmario added the refactor Code that needs to be refactored, i.e. outsource or rewrite label May 23, 2022
@Quimoniz
Copy link
Collaborator

When using the metricq.zi... webpage, the function doRequest() is still shown as part of the stacktrace, when examining the network requests. So yes it's still used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code that needs to be refactored, i.e. outsource or rewrite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmario @Quimoniz