Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize drawing of markers #30

Open
Quimoniz opened this issue Mar 1, 2021 · 0 comments
Open

Externalize drawing of markers #30

Quimoniz opened this issue Mar 1, 2021 · 0 comments
Labels
refactor Code that needs to be refactored, i.e. outsource or rewrite

Comments

@Quimoniz
Copy link
Collaborator

Quimoniz commented Mar 1, 2021

There are a lot of supported markers defined in Graticule.js in function parseStyleOptions(), beginning in Line 567. It would be more beautiful to separate the code for drawing all the markers. E.g. by putting it in a file markers.js.

As it is, the length of the function parseStyleOptions() exceeds the rule of thumb that functions should have a maximum of 100 lines of code with a line count of 278.
@Quimoniz Quimoniz added the refactor Code that needs to be refactored, i.e. outsource or rewrite label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code that needs to be refactored, i.e. outsource or rewrite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quimoniz