Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when applying texture packs (Resource Packs) #831

Closed
Gunner76th opened this issue Apr 24, 2017 · 10 comments
Closed

Crash when applying texture packs (Resource Packs) #831

Gunner76th opened this issue Apr 24, 2017 · 10 comments
Labels

Comments

@Gunner76th
Copy link

Thank you for reporting!

For issues:

  • If the issue seems to affect only one mod, report to them instead of here.
  • Remove NEI and FEI to see if they are causing the issue before reporting.
  • If you crashed, please paste the crash log to gist and link it here.

For suggestions:

  • Please do not suggest features from NEI. See this spreadsheet before requesting.
    The following crashes happen while two different resource packs were being applied.

https://pastebin.com/a7X54t37
https://pastebin.com/Cgsdc4x1

This has been cross posted to Soartex/Issues#9 as well as https://minecraft.curseforge.com/projects/glimmars-steampunk?comment=48 to their respective pack authors.

@mezz
Copy link
Owner

mezz commented Apr 24, 2017

Thanks for the report!
This is a JEI issue, not caused by any specific resource pack.

@mezz mezz added the bug label Apr 24, 2017
@mezz
Copy link
Owner

mezz commented Apr 24, 2017

I'm not able to reproduce this bug. Applying a resource pack makes JEI reload, and I think some mod is breaking when JEI reloads.
Can you paste your fml-client-latest.log to gist and link it here?

@Gunner76th
Copy link
Author

Here is the raw file. I had to rename it as a txt file due to upload restrictions. This is the most recent one that involved the crash while applying the resource pack. I am uploading the raw file, due to that fact I am on a satellite connection, and creating gists sometimes has issues due to that.
fml-client-2.log.txt

@Gunner76th
Copy link
Author

Gunner76th commented Apr 24, 2017

Also, incase it helps, here is the link to the modpack in question that is having the crash. This is a modpack that I/We (TeamIHOC) are maintaining.
If the problem is caused by a bad JSON file, then that would be because of Ex Nihilo's SieveRegistry.json file
The file I am linking here is the corrected JSON file https://cdn.discordapp.com/attachments/289539713587609601/306168709117116416/SieveRegistry.json
Seems I some how missed a single data entry in one of the "meshLevel": lines.

I have not retested since I corrected that particular error.

@mezz
Copy link
Owner

mezz commented Apr 24, 2017

Thanks, based on the log I can see that the vanilla JEI plugin is crashing because of some broken smelting recipe. I should be able to prevent it from crashing.

[13:21:04] [Client thread/ERROR] [JEI/JEI]: Failed to register mod plugin: class mezz.jei.plugins.vanilla.VanillaPlugin
java.lang.NullPointerException: Null item in itemStack
	at mezz.jei.util.StackHelper.getSubtypes(StackHelper.java:219) ~[StackHelper.class:?]
	at mezz.jei.plugins.vanilla.furnace.SmeltingRecipeMaker.getFurnaceRecipes(SmeltingRecipeMaker.java:29) ~[SmeltingRecipeMaker.class:?]
	at mezz.jei.plugins.vanilla.VanillaPlugin.register(VanillaPlugin.java:136) ~[VanillaPlugin.class:?]
	at mezz.jei.JeiStarter.registerPlugins(JeiStarter.java:142) [JeiStarter.class:?]
	at mezz.jei.JeiStarter.start(JeiStarter.java:48) [JeiStarter.class:?]
	at mezz.jei.ProxyCommonClient.loadComplete(ProxyCommonClient.java:111) [ProxyCommonClient.class:?]

@mezz
Copy link
Owner

mezz commented Apr 24, 2017

Please try with JEI build 418.
It should not crash, and you should see a log starting with "Found invalid smelting recipe: " that tries to describe the broken recipe.

@mezz
Copy link
Owner

mezz commented Apr 24, 2017

@Gunner76th any luck?

@Gunner76th
Copy link
Author

sorry, I have been working on installing an air conditioner this afternoon. I will load the new JEI in a few and test it once I am done.

@Gunner76th
Copy link
Author

I just tested build 418 with loading Glimmars Steampunk pack, and it applied with no crash.
fml-client-latest.log.txt
Here is a copy of my latest log. Hope this helps.

@mezz
Copy link
Owner

mezz commented Apr 25, 2017

Ok cool. Looks like the crash has been fixed. Now it just shows this error instead of crashing:
[Client thread/ERROR] [JEI/JEI]: Found invalid smelting recipe: (1x (null) -> 1xitem.flint_ingot@0 tp:flint_ingot)

@mezz mezz closed this as completed Apr 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants