Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug - Edge Addons] Sidepanel API reloads app on every tab #222

Open
bjohnsonfrontsteps opened this issue Nov 7, 2024 · 4 comments
Open
Assignees
Labels
Reviewing Currently reviewing this issue with Engineering team, will update post review

Comments

@bjohnsonfrontsteps
Copy link

In edge, an angular app is re-initialized each time the user switches tabs while the global sidepanel is open. In chrome, the app is not re-initialized (expected behavior)

To Reproduce Steps to reproduce the behavior:

  • Clone the repository at https://github.com/bjohnsonfrontsteps/extension-issue
  • npm install
  • run ng build
  • load unpacked the www output folder in both chrome and edge
  • click the extension to open the sidepanel. (this displays the reload count in the UI)
  • In edge, with the sidepanel open, switch between tabs and notice the reload count increment.
  • In chrome, with the sidepanel open, switch between tabs and notice the reload count remain at 1.

OS: [MacOS, Windows 11]
Browser [Edge]
Version [Version 130.0.2849.68 (Official build) (arm64)]

@ManikanthMSFT ManikanthMSFT self-assigned this Nov 8, 2024
@ManikanthMSFT ManikanthMSFT added the Reviewing Currently reviewing this issue with Engineering team, will update post review label Nov 8, 2024
@ManikanthMSFT
Copy link
Collaborator

Hi @bjohnsonfrontsteps, thank you for reporting this. We are looking into this and will let you know as soon as we have an update.

@shoopapa
Copy link

We are also running into this issue on mac and windows, specifically these versions of Edge

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36 Edg/131.0.0.0
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36 Edg/131.0.0.0

@ManikanthMSFT
Copy link
Collaborator

Hi @shoopapa, thank you for reporting this. We have forwarded this to our team and once we get an update we will write back to you.

@shoopapa
Copy link

Hi @ManikanthMSFT, bringing this up again.
Sidepanel extensions are highly hindered on edge, we are having to store nearly every state value into local storage to persist state when users switch tabs, very untenable. (our use case has a form and its common for users to change tabs to find the values they need)
Also happy to contribute if you can point me in the right direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Currently reviewing this issue with Engineering team, will update post review
Projects
None yet
Development

No branches or pull requests

3 participants