Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Leverage framework provided System.Text.Json on net 8 #5908

Closed
thompson-tomo opened this issue Apr 17, 2024 · 4 comments
Closed

.Net: Leverage framework provided System.Text.Json on net 8 #5908

thompson-tomo opened this issue Apr 17, 2024 · 4 comments
Assignees
@markwallace-microsoft
Labels
Build Features planned for next Build conference enhancement .NET Issue or Pull requests regarding .NET code

Comments

@thompson-tomo
Copy link

thompson-tomo commented Apr 17, 2024 •
edited
Loading

name: Feature request
about: Make STJ an optional dependency based upon TFM

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Text.Json as it is provided by the framework when also net 8

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Apr 17, 2024
@github-actions github-actions bot changed the title Add additional TFM so that framework can provide System.Text.Json .Net: Add additional TFM so that framework can provide System.Text.Json Apr 17, 2024
@Krzysztof318
Copy link
Contributor

this is in progress already #4421

@thompson-tomo
Copy link
Author

@Krzysztof318 i have just looked through the PR and i can't identify any places where the dependencies have been optimised based on the TFM

@markwallace-microsoft markwallace-microsoft self-assigned this Apr 19, 2024
@thompson-tomo
Copy link
Author

thompson-tomo commented May 31, 2024 •
edited
Loading

This has not been implemented based on what was merged via #4421 hence have submitted PR as #6479

@thompson-tomo thompson-tomo changed the title .Net: Add additional TFM so that framework can provide System.Text.Json .Net: Leverage framework provided System.Text.Json on nwt 8 May 31, 2024
@thompson-tomo thompson-tomo changed the title .Net: Leverage framework provided System.Text.Json on nwt 8 .Net: Leverage framework provided System.Text.Json on net 8 May 31, 2024
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue May 31, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
f557646
@thompson-tomo thompson-tomo mentioned this issue May 31, 2024
Closed
4 tasks
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 18, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
01621bc
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 18, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
ca081c0
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 19, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
eed8bb5
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 19, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
7a5a192
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 19, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
5daca72
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 20, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
50e9084
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 20, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
2b6d2f9
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jun 29, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
7607ac8
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jul 10, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
27412e8
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jul 16, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
10a3150
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jul 18, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
d5e91c1
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Jul 24, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
3aa4de1
thompson-tomo added a commit to thompson-tomo/semantic-kernel that referenced this issue Aug 6, 2024
@thompson-tomo
microsoft#5908 conditionalize dependencies
ca9012a
@markwallace-microsoft markwallace-microsoft moved this to Sprint: In Review in Semantic Kernel Aug 28, 2024
@markwallace-microsoft markwallace-microsoft added the Ignite Features planned for next Ignite conference label Aug 28, 2024
@markwallace-microsoft markwallace-microsoft removed the Ignite Features planned for next Ignite conference label Nov 4, 2024
@markwallace-microsoft markwallace-microsoft added the Build Features planned for next Build conference label Jan 7, 2025
@markwallace-microsoft
Copy link
Member

@dmytrostruk is going to continue this work, tracking with #8109., the associated PR will be updated as part of this task

@markwallace-microsoft markwallace-microsoft moved this from Community PRs to Sprint: Done in Semantic Kernel Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
Build Features planned for next Build conference enhancement .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: #5908 conditionalize dependencies thompson-tomo/semantic-kernel
4 participants
@matthewbolanos @thompson-tomo @Krzysztof318 @markwallace-microsoft