Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to definition does not work #15918

Closed
SergeyHein opened this issue Aug 4, 2024 · 5 comments
Closed

Go to definition does not work #15918

SergeyHein opened this issue Aug 4, 2024 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster notebook-intellisense Intellisense & other language features in notebook cells for any language

Comments

@SergeyHein
Copy link

Environment data

Version: 1.92.0 (user setup)
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631
Python : 3.11 on WSL
Type of virtual environment used : poetry
Jupyter server running: Local
Jupyter plugin : v2024.8.2024080201 (pre-release)

Expected behaviour

Go to definition works in jupyter notebook

Actual behaviour

Go to definition does not work in jupyter notebook

Steps to reproduce:

write a simple code in jupyter like

from pathlib import Path
click Go to definition

Details

goto_definition_doesnotwork

Note: neither release not pre-release work

@SergeyHein SergeyHein added the bug Issue identified by VS Code Team member as probable bug label Aug 4, 2024
@DonJayamanne
Copy link
Contributor

Thanks for filing this issue, sorry you are running into this.

Do you have the Pylance extension installed, if not, then its a duplicate of the issue microsoft/vscode-python#23897

@DonJayamanne DonJayamanne added info-needed Issue requires more information from poster notebook-intellisense Intellisense & other language features in notebook cells for any language labels Aug 5, 2024
@SergeyHein
Copy link
Author

SergeyHein commented Aug 12, 2024

thanks for a feedback.

I just tried on a different box - it works (???)

Here is env snapshot of a box where it works ( WSL again) - please note that pylance is installed

Version: 1.92.1 (user setup)
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
Date: 2024-08-07T20:16:39.455Z (4 days ago)
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631

Just in case here is a full list of installed extentions

code --list-extensions | xargs -L 1 echo code --install-extension

code --install-extension alexcvzz.vscode-sqlite
code --install-extension batisteo.vscode-django
code --install-extension donjayamanne.python-environment-manager
code --install-extension donjayamanne.python-extension-pack
code --install-extension github.copilot
code --install-extension github.copilot-chat
code --install-extension googlecloudtools.cloudcode
code --install-extension kevinrose.vsc-python-indent
code --install-extension ms-python.black-formatter
code --install-extension ms-python.debugpy
code --install-extension ms-python.isort
code --install-extension ms-python.python
code --install-extension ms-python.vscode-pylance
code --install-extension ms-toolsai.jupyter
code --install-extension ms-toolsai.jupyter-keymap
code --install-extension ms-toolsai.jupyter-renderers
code --install-extension ms-toolsai.vscode-jupyter-cell-tags
code --install-extension ms-toolsai.vscode-jupyter-slideshow
code --install-extension njpwerner.autodocstring
code --install-extension visualstudioexptteam.intellicode-api-usage-examples
code --install-extension visualstudioexptteam.vscodeintellicode
code --install-extension wholroyd.jinja
code --install-extension xelad0m.jupyter-toc
code --install-extension zeshuaro.vscode-python-poetry

Let me know if you need any further info

@DonJayamanne
Copy link
Contributor

Please can you disable all extensions, except for Jupyter, Python and Pylance and verify it works.

@SergeyHein
Copy link
Author

Hey, @DonJayamanne , I can't reproduce the issue anymore, looks like recent updates of vscode / plugins solved it.

@DonJayamanne
Copy link
Contributor

Thank you very much for getting back with an update

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster notebook-intellisense Intellisense & other language features in notebook cells for any language
Projects
None yet
Development

No branches or pull requests

2 participants