-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoStartBrowser starts the wrong url #580
Comments
Hi! Sent some messages in the PR thread but better news is I think we already have a solution that may work for you! There is a option to configure |
Hmm yeah that is a valid alternative to work with. So basically this sets the serverReadyAction manually, whereas the proposed |
looping in @connor4312 since he is the expert of this setting, wondering if he has any advice to make it automatic or better for your use case |
Yea. I don't know how the Python implementation of autoStartBrowserURL works, but maybe |
The python implementation you mean from debugpy or from the debugger extension? I looked and the debugger passes on the arguments without editing |
looping in @rchiodo as well |
AFAIK, debugpy doesn't handle the autoStartBrowser configuration. The extension does here: vscode-python-debugger/src/extension/debugger/configuration/resolvers/launch.ts Lines 149 to 156 in 4d27e65
Not sure if that means the serverReadyAction wouldn't work because there would be duplicates? |
Yea, looks like that would overwrite |
Hi! I have put in a fix for this so it doesn't overwrite the setting if present, @maxschmi if you are able to get the most recent pre-release version of the vscode python debugger (latest released should say this morning) and give it a try to let me know if that works that would be great, thanks! |
Hey @eleanorjboyd I'm not so sure what to test. I did install the latest pre-release, but the "autoStartBrowserURL" option is not available. But I guess you decided against the pattern option. If I have :
The "serverReadyAction" is executed, but unfortunatly is not detecting or not using the correct port, but instead uses 3000 as a port. |
context
I have a
django
app and customized mydjangoadmin runserver
command to also start avite
debugging server for my frontend.Therefor when starting my debugging server I get two url's in my stdout of
djangoadmin runserver
.Problem
When I want to use the
autoStartBrowser:true
option of mydebugpy
setup to automatically start a browser, it starts the wrong URL. So my vite server-URL is started in the Browser instead of my django webpage.Sugested solution
Add an additional setting to customize the startup URL. E.g.:
The text was updated successfully, but these errors were encountered: