From 49d8e4175a12b3d65eb15741c0b2f13ff7bd391d Mon Sep 17 00:00:00 2001
From: Anthony Kim <anthonykim@microsoft.com>
Date: Tue, 3 Dec 2024 19:28:30 -0800
Subject: [PATCH] update where isWindows is

---
 src/client/common/configSettings.ts            | 3 +--
 src/client/common/platform/platformService.ts  | 6 +-----
 src/client/common/terminal/service.ts          | 2 +-
 src/client/common/utils/platform.ts            | 4 ++++
 src/test/common/terminals/service.unit.test.ts | 3 ++-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts
index 1b637e7aac2d..875e4b1baa6c 100644
--- a/src/client/common/configSettings.ts
+++ b/src/client/common/configSettings.ts
@@ -36,8 +36,7 @@ import {
 } from './types';
 import { debounceSync } from './utils/decorators';
 import { SystemVariables } from './variables/systemVariables';
-import { getOSType, OSType } from './utils/platform';
-import { isWindows } from './platform/platformService';
+import { getOSType, OSType, isWindows } from './utils/platform';
 import { untildify } from './helpers';
 
 export class PythonSettings implements IPythonSettings {
diff --git a/src/client/common/platform/platformService.ts b/src/client/common/platform/platformService.ts
index aa139eeeebc0..dc9b04cc652c 100644
--- a/src/client/common/platform/platformService.ts
+++ b/src/client/common/platform/platformService.ts
@@ -7,7 +7,7 @@ import { injectable } from 'inversify';
 import * as os from 'os';
 import { coerce, SemVer } from 'semver';
 import { getSearchPathEnvVarNames } from '../utils/exec';
-import { Architecture, getArchitecture, getOSType, OSType } from '../utils/platform';
+import { Architecture, getArchitecture, getOSType, isWindows, OSType } from '../utils/platform';
 import { parseSemVerSafe } from '../utils/version';
 import { IPlatformService } from './types';
 
@@ -73,7 +73,3 @@ export class PlatformService implements IPlatformService {
         return getArchitecture() === Architecture.x64;
     }
 }
-
-export function isWindows(): boolean {
-    return getOSType() === OSType.Windows;
-}
diff --git a/src/client/common/terminal/service.ts b/src/client/common/terminal/service.ts
index 29b0e5be5fc0..e37539f1bc7c 100644
--- a/src/client/common/terminal/service.ts
+++ b/src/client/common/terminal/service.ts
@@ -21,7 +21,7 @@ import {
 } from './types';
 import { traceVerbose } from '../../logging';
 import { getConfiguration } from '../vscodeApis/workspaceApis';
-import { isWindows } from '../platform/platformService';
+import { isWindows } from '../utils/platform';
 
 @injectable()
 export class TerminalService implements ITerminalService, Disposable {
diff --git a/src/client/common/utils/platform.ts b/src/client/common/utils/platform.ts
index cf3b28e5cc35..c86f5ff9364e 100644
--- a/src/client/common/utils/platform.ts
+++ b/src/client/common/utils/platform.ts
@@ -67,3 +67,7 @@ export function getUserHomeDir(): string | undefined {
     }
     return getEnvironmentVariable('HOME') || getEnvironmentVariable('HOMEPATH');
 }
+
+export function isWindows(): boolean {
+    return getOSType() === OSType.Windows;
+}
diff --git a/src/test/common/terminals/service.unit.test.ts b/src/test/common/terminals/service.unit.test.ts
index 15e0d46ad9e1..147803a72598 100644
--- a/src/test/common/terminals/service.unit.test.ts
+++ b/src/test/common/terminals/service.unit.test.ts
@@ -24,6 +24,7 @@ import { IServiceContainer } from '../../../client/ioc/types';
 import { ITerminalAutoActivation } from '../../../client/terminals/types';
 import { createPythonInterpreter } from '../../utils/interpreters';
 import * as workspaceApis from '../../../client/common/vscodeApis/workspaceApis';
+import * as platform from '../../../client/common/utils/platform';
 
 suite('Terminal Service', () => {
     let service: TerminalService;
@@ -95,7 +96,7 @@ suite('Terminal Service', () => {
         mockServiceContainer.setup((c) => c.get(ITerminalActivator)).returns(() => terminalActivator.object);
         mockServiceContainer.setup((c) => c.get(ITerminalAutoActivation)).returns(() => terminalAutoActivator.object);
         getConfigurationStub = sinon.stub(workspaceApis, 'getConfiguration');
-        isWindowsStub = sinon.stub(platformService.object, 'isWindows');
+        isWindowsStub = sinon.stub(platform, 'isWindows');
         pythonConfig = TypeMoq.Mock.ofType<WorkspaceConfiguration>();
         editorConfig = TypeMoq.Mock.ofType<WorkspaceConfiguration>();
         getConfigurationStub.callsFake((section: string) => {