Don't show lightbulbs for Jedi when editing a line

[cplager]

Issue Type: Bug

I keep getting lightbulbs with bad information. This happens on almost every line I edit. This is a regression that showed up when I updated VSCode a week ago. It did not change when I updated today.

VS Code version: Code 1.54.1 (f30a9b73e8ffc278e71575118b6bf568f04587c8, 2021-03-04T22:38:31.419Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: enabled rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.88GB (16.40GB free)
Process Argv	--crash-reporter-id 3dfdb70b-45e2-453d-9eed-640393392895
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
githistory	don	0.6.14
align-by-regex	jan	1.0.4
gzip-decompress	mao	1.0.0
csharp	ms-	1.23.9
python	ms-	2021.2.625869727
jupyter	ms-	2021.3.619093157
remote-wsl	ms-	0.54.2
cpptools	ms-	1.2.2
hexeditor	ms-	1.4.0
vscode-ipython	pan	0.5.0
best-dark-themes-pack	the	1.0.2
material-theme	zhu	3.9.15

(15 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30265442
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstry244:30256636
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
dockersubsetcf:30265999
pythontb:30265425
vspre833:30267464

[cplager]

Why was this closed?

Am I not correct that this is not the correct behavior?

[brettcannon]

We are considering this a feature request, so it wasn't closed, just reclassified. The light bulbs are directly provided by Jedi, so shutting them off isn't a bug in our view but a request to provide an option to not have them show up.

[cplager]

It's not that I don't want a light bulb. I don't want a light bulb that has crap suggestions.

So, yes, it might be nice to be able to turn off the light bulb. But it never makes sense to have the light bulb pop up with clearly wrong/bad ideas.

Note: The title of the request was changed by somebody else. The point has always been that the information provided by the light bulb is wrong.

[luabud]

These suggestions are refactoring options. You may not wish to use them but them they are not incorrect. We can improve the wording and even the function name generated, the suggestions aren't wrong.

[cplager]

They are wrong. If I have it implement what it proposes in the lightbulb, it breaks the code.

It's really not a feature. It's a bug.

[brettcannon]

Moved to #17241