-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
venv: option to disable PS1 change on venv activation #22728
Comments
Hi @tonywu6 , thanks for reaching out. Can you describe the issue with screenshots as to what exactly is different? We try setting |
Thanks for all the details in the screenshots, I really appreciate it. Have a look at this: vscode-python/src/client/terminals/envCollectionActivation/service.ts Lines 381 to 390 in db6e15e
where we avoid setting PS1 if
Output for
|
Python output
|
I think I got it ...
I manually set it in my .zshrc and the feature is working as expected now. Sorry and thanks 😅 |
Type: Feature Request
This is a feedback for the
pythonTerminalEnvVarActivation
experiment.Related: #22611, #11039, #22056
I like the new way of activating venvs. I do have a thing to nitpick about, which is that people may already have configured their terminal to display current venvs (like spaceship) and so it'd be great if there's an option to prevent VS Code from modifying that (in other words "don't mess with my beautiful PS1" 😅)
Diagnostic data
python.languageServer
setting: PylanceUser Settings
Extension version: 2023.22.1
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:16.874Z)
OS version: Darwin arm64 23.2.0
Modes:
The text was updated successfully, but these errors were encountered: