Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Current Session" commands are still REPL commands after exiting REPL #22780

Closed
andreamah opened this issue Jan 23, 2024 · 2 comments
Closed
Assignees
Labels
area-repl triage-needed Needs assignment to the proper sub-team

Comments

@andreamah
Copy link

Testing #22647

  1. Open the Python REPL and run some commands.
  2. Use quit() to leave the REPL.
  3. Run recent command
  4. The "current session" lists the commands that you used in your REPL, which are no longer valid in the current terminal because you existed the REPL. 🐛
image

Maybe this is out of your control and needs to be in the API for contributing recent commands- I just think that the recent commands should reflect what is valid in the current terminal.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 23, 2024
@anthonykim1
Copy link

I think we would be able to 'separate' out different shell's history if I add and define Python shell type just like how there are pwsh, bash, zsh, etc defined in the core repo. Good catch!

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Jan 26, 2024
@anthonykim1 anthonykim1 added area-repl and removed info-needed Issue requires more information from poster labels Jan 26, 2024
@anthonykim1
Copy link

this should be fixed now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-repl triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants