Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-specific remote settings is ignored #23290

Closed
jhrmnn opened this issue Apr 9, 2024 · 9 comments
Closed

Python-specific remote settings is ignored #23290

jhrmnn opened this issue Apr 9, 2024 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@jhrmnn
Copy link
Member

jhrmnn commented Apr 9, 2024

I wasn't able to submit the Issue from VS Code, "Create on Github" in the Issue Reporter would do nothing.

Behaviour

Expected vs. Actual

Remote settings in the [python] section should be applied to Python files but it is ignored with v2024.4.0. Downgrading to v2024.2.1 resolves this issue. Upgrading back to v2024.4.0 then retains the correct behavior.

Steps to reproduce:

  1. Launch VS Code in a dev container or for a Github Codespace that specifies a Python-specific VS code settings (customizations.vscode.settings.[python])
  2. Observe that the settings is not applied.

Diagnostic data

  • Python version (& distribution if applicable, e.g. Anaconda): 3.10.14
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
  • Value of the python.languageServer setting: Default
Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

User Settings


languageServer: "Pylance"

testing
• pytestArgs: "<placeholder>"
• pytestEnabled: true

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 9, 2024
@jhrmnn
Copy link
Member Author

jhrmnn commented Apr 9, 2024

Just found out it's not necessary to downgrade the extension, it's sufficient to simply reload the VS Code window (Developer: Reload Window).

@karthiknadig
Copy link
Member

Did you reload after installing 2024.4.0 ? or was this reload with a different version?

Python extension does not do anything special here, all we do is rely on VS code to read setting. It is likely that the dev-container settings are not seen by vscode.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Apr 9, 2024
@jhrmnn
Copy link
Member Author

jhrmnn commented Apr 10, 2024

The reload was with the latest version, 2024.4.0. So I found only after posting the original Issue that downgrading is not necessary, all the the downgrade did was forcing me to reload, and it’s the reload itself that resolves the issue. Which is, of course, inconvenient.

So to state it again, the remote Python-specific settings is not seen by vscode (filtering settings for @lang:python @modifed gives nothing), and after “Developer: Reload Window”, it is seen.

I don’t remember this being the case some time ago, but of course other things than the Python extension might have changed. Will try to find the root cause. Any tips what to look for?

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Apr 10, 2024
@jhrmnn
Copy link
Member Author

jhrmnn commented Apr 10, 2024

Should I then likely re-file the Issue with VS Code core then?

@jhrmnn
Copy link
Member Author

jhrmnn commented Apr 10, 2024

Just confirmed that the same thing happens when the Codespace is launched in browser on github.dev instead of in VS Code. As in, on first load the Python-specific settings is ignored and on browser reload it is respected.

@karthiknadig karthiknadig self-assigned this Apr 10, 2024
@karthiknadig karthiknadig changed the title [v2024.4.0] Python-specific remote settings is ignored Python-specific remote settings is ignored Apr 12, 2024
@karthiknadig
Copy link
Member

Moving this to VS Code as this is related to the settings.

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Apr 12, 2024
@karthiknadig karthiknadig removed their assignment Apr 12, 2024
@vscodenpa vscodenpa removed the triage-needed Needs assignment to the proper sub-team label Apr 12, 2024
@bpasero
Copy link
Member

bpasero commented Apr 12, 2024

@karthiknadig please, when moving an issue into here, assign an owner. These issues are not automatically assigned.

@rebornix rebornix transferred this issue from microsoft/vscode Apr 23, 2024
@rebornix rebornix removed their assignment Apr 23, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 23, 2024
@karthiknadig
Copy link
Member

@jhrmnn Can you share the settings under the [python], are they test specific settings?

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Apr 24, 2024
@eleanorjboyd
Copy link
Member

Hello! I am closing this issue since we have not heard back on the above question, please comment with the requested information if you are still experiencing this problem and I can re-open it. Thanks

@eleanorjboyd eleanorjboyd closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

6 participants