Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support alternate language servers in python.languageServer #23640

Closed
DetachHead opened this issue Jun 19, 2024 · 2 comments
Closed

support alternate language servers in python.languageServer #23640

DetachHead opened this issue Jun 19, 2024 · 2 comments
Labels
feature-request Request for new features or functionality needs community feedback Awaiting community feedback

Comments

@DetachHead
Copy link

currently there are only 3 options in python.LanguageServer: "Pylance", "Jedi" and "None". this isn't ideal for a couple of reasons:

  • if anyone wants to use an extension that provides an alternative language server, they have to set this setting to "None" to avoid conflicting with one of those two built in language servers, which is confusing to the user. they would expect their language server to just show up as an option in that list.
  • i want to be able to support jupyter notebooks in my language server, but i can't because there doesn't seem to be a way to do so without changing this hardcoded extension ID to my own extension ID and tricking it into thinking it's interfacing with pylance by implementing a PylanceApi in my extension. this would be fine, if it weren't for the fact that i'd have to fork vscode-python just to change one hardcoded constant. ideally my users of my language server shouldn't have to install two different extensions.

perhaps there could be a CustomLanguageServerApi interface similar to PylanceApi that extensions can implement and register as an option in python.languageServer.

@DetachHead DetachHead added the feature-request Request for new features or functionality label Jun 19, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 19, 2024
@karthiknadig karthiknadig added needs community feedback Awaiting community feedback and removed triage-needed Needs assignment to the proper sub-team labels Jun 24, 2024
Copy link

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@DetachHead
Copy link
Author

after looking at how ruff supports jupyter notebooks, i think it's possible without this functionality, so i'll close this issue.

@DetachHead DetachHead closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality needs community feedback Awaiting community feedback
Projects
None yet
Development

No branches or pull requests

2 participants