Skip to content

All symbols are optional #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylerjwatson opened this issue Jul 10, 2018 · 1 comment · Fixed by #20
Open

All symbols are optional #19

tylerjwatson opened this issue Jul 10, 2018 · 1 comment · Fixed by #20
Labels
ADO to GitHub automation label Issue caused by core project dependency modules or library

Comments

@tylerjwatson
Copy link

tylerjwatson commented Jul 10, 2018

All symbols in these typings are optional, making concrete implementations of these object an unnecessarily huge task. Only fields marked as optional in the graph documentation should be marked as optional with the ?: specifier, all others should be declared as normal.

If the interface needs to be marked as optional, Partial<T> should be used instead.
AB#7043

@muthurathinam
Copy link
Contributor

In particular the Entity type’s id and the createdDateTime and lastModifiedDateTime fields are now not nullable. This makes list creation in SharePoint problematic since those fields are server generated and shouldn’t be expected when you’re doing a POST to create a list or Column Definition (both of which derive from those base types).

@muthurathinam muthurathinam reopened this Sep 19, 2018
@ddyett ddyett added the ADO to GitHub automation label Issue caused by core project dependency modules or library label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO to GitHub automation label Issue caused by core project dependency modules or library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants