Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking frame/loading in image file as comparison #4

Open
DVark09 opened this issue May 17, 2021 · 5 comments
Open

Masking frame/loading in image file as comparison #4

DVark09 opened this issue May 17, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@DVark09
Copy link

DVark09 commented May 17, 2021

Being able to either add an image with an alpha channel or modifying a frame to check for the exact thing you are looking for would help in my opinion. The run I'm trying it on has a static load text but there are different backgrounds behind the text every time, making the similarity go down and getting the desired time periods hard.

@milankarman
Copy link
Owner

Great idea. This is definitely something I would like to add, though I'm not sure how much new work and how many changes this would need yet.
Could you let me know what the game you're talking about here is? I'd like to use videos of it for testing for when I get to this.

@milankarman milankarman added the enhancement New feature or request label May 17, 2021
@DVark09
Copy link
Author

DVark09 commented May 17, 2021

I guess the easier solution would be to allow uploading images and then just using the same coparison. Probably to allow alpha channels some modification needs to be done, but I'm guessing it wouldn't be that bad. Maybe it wouldn't even require anything at all, if your codebase can handle transparency (I haven't checked code, sorry) I saw this being implemented on the image autosplitter (Auto-split) but that was written in Python. Maybe if I have some free time I'll try to see how that works.
The game I was testing on is called Sniper: Path of Vengeance

@milankarman
Copy link
Owner

Thanks for letting me know. I have some ideas on how to implement this but I'll just have to try them and see if they work haha.

@Avasam
Copy link
Contributor

Avasam commented Feb 3, 2022

If you need some inspiration for implementation, feel free to checkout how AutoSplit does it! https://github.com/Toufool/Auto-Split/blob/2.0.0/src/compare.py

Do note that perceptual hash tends to be inaccurate with masking.

@milankarman
Copy link
Owner

milankarman commented Feb 3, 2022

If you need some inspiration for implementation, feel free to checkout how AutoSplit does it! https://github.com/Toufool/Auto-Split/blob/2.0.0/src/compare.py

Do note that perceptual hash tends to be inaccurate with masking.

Thanks for the tip. I'm not sure I want to add this anytime soon as demand for it pretty much seems to have disappeared and it seemed like a lot of work (that also didn't fit any of my personal use cases). I could definitely change my mind on it though if there's more demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants