Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlx-lm] Allow samplers to be chainable #1219

Open
awni opened this issue Jan 22, 2025 · 1 comment · May be fixed by #1330
Open

[mlx-lm] Allow samplers to be chainable #1219

awni opened this issue Jan 22, 2025 · 1 comment · May be fixed by #1330

Comments

@awni
Copy link
Member

awni commented Jan 22, 2025

In mlx_lm if you set top_p and top_k you will only get one top_p sampler instead of a hybrid which does both.
@chimezie
Copy link
Contributor

Composable samplers would be great

@neilmehta24 neilmehta24 mentioned this issue Jan 27, 2025
Closed
@neilmehta24 neilmehta24 linked a pull request Mar 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make_sampler creates sampler chain with all sampling parameters neilmehta24/mlx-examples
2 participants
@chimezie @awni