mx.repeat with variable number of repetitions, issue #1785
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisljak
changed the title
mx.repeat with variable number of repetitionsmx.repeat with variable number of repetitions, issue #1785
kisljak
changed the title
mx.repeat with variable number of repetitions, issue #1785mx.repeat with variable number of repetitions, issue https://github.com/ml-explore/mlx/issues/1785
kisljak
changed the title
mx.repeat with variable number of repetitions, issue https://github.com/ml-explore/mlx/issues/1785mx.repeat with variable number of repetitions, issue #1785
|
MLX doesn't support ops with a data dependent output size yet unfortunately. This op assumes that the repeats is a vector available when called so it would not solve the linked issue which requires an array as the repeats argument. I will close it but feel to post on the issue for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1785
Implementation of
mx.repeatfor variable number of repetitions. I also updated checking of axis in a methodtile, which was only using duplicit code already implemented elsewhere.Finally I added tests to check the new functionality
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes