Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for Window's path format in Gromet generation. #338

Open
vincentraymond-ua opened this issue Jan 5, 2023 · 0 comments
Open

Comments

@vincentraymond-ua
Copy link
Contributor

vincentraymond-ua commented Jan 5, 2023

There are currently a couple of small bugs where inaccurate Gromet is generated if running the program analysis pipeline on a Windows machine. This is due to the differences in path format between MacOS/Linux and Windows.

These both can likely be fixed using the Python os module to handle paths when necessary.

Instance 1: The GrometFNModule "name" field.

 "modules": [
        {
            "schema": "FN",
            "schema_version": "0.1.4",
            "name": "C:\\Users\\Example\\AppData\\Local\\Temp\\tmpdpbxdnjh\\penn_chime\\cli",

Instance 2: The GrometFNModuleCollection "module_index" and "executables" fields

"module_index": [
        "penn_chime\\cli\n",
        "penn_chime\\constants\n",
        "penn_chime\\model\\parameters\n",
        "penn_chime\\model\\sir\n",
        "penn_chime\\model\\validators\\base\n",
        "penn_chime\\model\\validators\\validators\n"
    ],
"executables": [
    "penn_chime\\cli\n"
]

This likely can be fixed in multifile_ingester.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant