From 0a33a28b18cabbd1710a761816de197a2916b014 Mon Sep 17 00:00:00 2001 From: Miguel Liezun Date: Thu, 21 Nov 2024 22:51:15 +0100 Subject: [PATCH] Publish to ducker hub in github actions (#47) * Publish to ducker hub in github actions * Update fastapi version in tests --- .github/workflows/docker-publish.yml | 68 +++++++++++----------------- tests/fastapi/requirements.txt | 2 +- 2 files changed, 28 insertions(+), 42 deletions(-) diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml index 0ef0851..bea5a20 100644 --- a/.github/workflows/docker-publish.yml +++ b/.github/workflows/docker-publish.yml @@ -2,19 +2,17 @@ name: Docker on: push: - # branches: [ "main" ] - # Publish semver tags as releases. tags: [ 'v*.*.*' ] pull_request: branches: [ "main" ] env: # Use docker.io for Docker Hub if empty - REGISTRY: ghcr.io + REGISTRY_GHCR: ghcr.io + REGISTRY_DOCKER_HUB: docker.io # github.repository as / IMAGE_NAME: ${{ github.repository }} - jobs: build: strategy: @@ -25,71 +23,59 @@ jobs: permissions: contents: read packages: write - # This is used to complete the identity challenge - # with sigstore/fulcio when running outside of PRs. id-token: write steps: - name: Checkout repository uses: actions/checkout@v3 - # Install the cosign tool except on PR - # https://github.com/sigstore/cosign-installer - name: Install cosign if: github.event_name != 'pull_request' - uses: sigstore/cosign-installer@6e04d228eb30da1757ee4e1dd75a0ec73a653e06 #v3.1.1 + uses: sigstore/cosign-installer@6e04d228eb30da1757ee4e1dd75a0ec73a653e06 with: cosign-release: 'v2.1.1' - # Set up BuildKit Docker container builder to be able to build - # multi-platform images and export cache - # https://github.com/docker/setup-buildx-action - name: Set up Docker Buildx - uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 + uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 - # Login against a Docker registry except on PR - # https://github.com/docker/login-action - - name: Log into registry ${{ env.REGISTRY }} + # Log into GitHub Container Registry + - name: Log into GitHub Container Registry if: github.event_name != 'pull_request' - uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d with: - registry: ${{ env.REGISTRY }} + registry: ${{ env.REGISTRY_GHCR }} username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} - # Extract metadata (tags, labels) for Docker - # https://github.com/docker/metadata-action + # Log into Docker Hub + - name: Log into Docker Hub + if: github.event_name != 'pull_request' + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d + with: + registry: ${{ env.REGISTRY_DOCKER_HUB }} + username: ${{ secrets.DOCKER_USERNAME }} + password: ${{ secrets.DOCKER_PASSWORD }} + - name: Extract Docker metadata id: meta - uses: docker/metadata-action@96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0 + uses: docker/metadata-action@96383f45573cb7f253c731d3b3ab81c87ef81934 with: - images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} + images: | + ${{ env.REGISTRY_GHCR }}/${{ env.IMAGE_NAME }} + ${{ env.REGISTRY_DOCKER_HUB }}/${{ env.IMAGE_NAME }} - # Build and push Docker image with Buildx (don't push on PR) - # https://github.com/docker/build-push-action - name: Build and push Docker image id: build-and-push - uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0 + uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 with: context: . push: ${{ github.event_name != 'pull_request' }} build-args: PY_VERSION=${{ matrix.python-version }} - tags: "${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ endsWith(github.ref_name, '/merge') && 'dev' || github.ref_name }}-py${{ matrix.python-version }},${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest-py${{ matrix.python-version }}" + tags: | + ${{ env.REGISTRY_GHCR }}/${{ env.IMAGE_NAME }}:${{ endsWith(github.ref_name, '/merge') && 'dev' || github.ref_name }}-py${{ matrix.python-version }} + ${{ env.REGISTRY_GHCR }}/${{ env.IMAGE_NAME }}:latest-py${{ matrix.python-version }} + ${{ env.REGISTRY_DOCKER_HUB }}/${{ env.IMAGE_NAME }}:${{ endsWith(github.ref_name, '/merge') && 'dev' || github.ref_name }}-py${{ matrix.python-version }} + ${{ env.REGISTRY_DOCKER_HUB }}/${{ env.IMAGE_NAME }}:latest-py${{ matrix.python-version }} labels: ${{ steps.meta.outputs.labels }} cache-from: type=gha cache-to: type=gha,mode=max - - # Sign the resulting Docker image digest except on PRs. - # This will only write to the public Rekor transparency log when the Docker - # repository is public to avoid leaking data. If you would like to publish - # transparency data even for private images, pass --force to cosign below. - # https://github.com/sigstore/cosign - # - name: Sign the published Docker image - # if: ${{ github.event_name != 'pull_request' }} - # env: - # # https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable - # TAGS: ${{ steps.meta.outputs.tags }} - # DIGEST: ${{ steps.build-and-push.outputs.digest }} - # # This step uses the identity token to provision an ephemeral certificate - # # against the sigstore community Fulcio instance. - # run: echo "${TAGS}" | xargs -I {} cosign sign --yes {}@${DIGEST} diff --git a/tests/fastapi/requirements.txt b/tests/fastapi/requirements.txt index bc6784d..4f7bfa9 100644 --- a/tests/fastapi/requirements.txt +++ b/tests/fastapi/requirements.txt @@ -1,7 +1,7 @@ annotated-types==0.6.0 anyio==4.3.0 exceptiongroup==1.2.1 -fastapi==0.110.3 +fastapi==0.115.4 idna==3.7 pydantic==2.7.1 pydantic_core==2.18.2