Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android app fails to compile #7

Open
nico202 opened this issue Nov 16, 2016 · 3 comments
Open

Android app fails to compile #7

nico202 opened this issue Nov 16, 2016 · 3 comments

Comments

@nico202
Copy link
Contributor

nico202 commented Nov 16, 2016

Hi, while compiling the android app I get an error due to the undefined:

android:layout_below="@+id/textView1"

Removing this line does work, IDK what it should be replaced with

@Nyran
Copy link
Collaborator

Nyran commented Nov 16, 2016

Hi Nico,

unfortunately I am busy right now and can not check the Sine-Emitter myself. However, I can tell you that the App worked last year as is.

If the removal of the app fixes the compilation issue for you, then you may consider fixing it.

In the end, as far as I remember, the Sine-Emitter just consisted of a Drop-Down menu for the frequency to be emitted, two sliders for the sine and pause length, and a few buttons.

I even think, that we forgot to fix the Pause Button. So just press "Play" several times to turn the sound on and off.

I am looking forward for your feedback and experience with the system.

Kind regards,

Adrian

@nico202
Copy link
Contributor Author

nico202 commented Nov 16, 2016

I can confirm that removing the line fixes the compilation and the app "just works" (I think it was a warning that turned into an error with the new gradle version or something like that).
And I can confirm the pause button not working (to stop i need to press "apply sine settings" to pause it).

Maybe I'll pull request later

@Nyran
Copy link
Collaborator

Nyran commented Nov 16, 2016

Of course, do as you feel fit.

Since it appears that you have interest in the project, it may be even worth considering to clean up and restructure the code base a bit. I am not able to do this before February, but I'll consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants