Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Bluebird.noConflict() to restrict impact on the global JS scope #147

Open
semmel opened this issue Sep 27, 2019 · 0 comments
Open

Comments

@semmel
Copy link

semmel commented Sep 27, 2019

Loading mr's bootstrap.js and consequently bluebird.min.js overrides the global Promise object. I would think that this is a unintended side-effect of Mr?

Yes I know that Bluebird is well-tested and compatible with the native implementations, but I this introduces a unnecessary dependency for all my code. What if a future version of Bluebird contains an error?

It seems to be easy to fix by appending .noConflict():

// file: bootstrap.js, line 181
function allModulesLoaded() {
            Promise = bootRequire("promise").noConflict();
// ..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant