Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Legacy file is not showing any errors #238

Open
purnendudash opened this issue May 9, 2024 · 2 comments
Open

Feature Request: Legacy file is not showing any errors #238

purnendudash opened this issue May 9, 2024 · 2 comments
Labels
question Further information is requested

Comments

@purnendudash
Copy link

If we do check any plugin via code checker and have file like this

https://moodledev.io/docs/4.4/apis/commonfiles#libphp

even

file like - https://moodledev.io/docs/4.4/apis/commonfiles#locallibphp

It does not showing any warning / error. There should be some checking about the legacy thing.

Kindly let me know if this feature is already there via some config etc.

@stronk7
Copy link
Member

stronk7 commented May 17, 2024

Hi @purnendudash ,

I'm not sure if I'm following, I'm not aware of any restriction to check those lib.php or locallib.php files.

Just to test it, I've run the codechecker from the web, setting mod/label as the path to examine, and it's finding the problems in mod/label/lib.php perfectly.

mod_label_lib

So, not sure which your problem can be, those files are, so far, checked.

Ciao :-)

@stronk7 stronk7 added the question Further information is requested label May 17, 2024
@Jayanta7022
Copy link

Jayanta7022 commented May 17, 2024

Screenshot 2024-05-17 171824

In new structure in some places the locallib.php has become a Legacy file. It would be a huge help if your code checker suggests us that it is a legacy file .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants