From d5240362fb7628ec92c8097868bcfbf258f6437e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Fri, 17 Jan 2025 15:28:16 +0100 Subject: [PATCH] MOBILE-4690 quiz: Check empty units on numerical question --- .../qtype/numerical/services/handlers/numerical.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/addons/qtype/numerical/services/handlers/numerical.ts b/src/addons/qtype/numerical/services/handlers/numerical.ts index 292e2e1e439..2883e0ab9bb 100644 --- a/src/addons/qtype/numerical/services/handlers/numerical.ts +++ b/src/addons/qtype/numerical/services/handlers/numerical.ts @@ -216,12 +216,12 @@ export class AddonQtypeNumericalHandlerService implements CoreQuestionHandler { return Translate.instant('addon.qtype_numerical.invalidnumber'); } - if (!question.parsedSettings) { - if (this.hasSeparateUnitField(question)) { - return Translate.instant('addon.qtype_numerical.unitnotselected'); - } + if (this.hasSeparateUnitField(question) && !unit) { + return Translate.instant('addon.qtype_numerical.unitnotselected'); + } - // We cannot know if the answer should contain units or not. + if (!question.parsedSettings) { + // We cannot check anything else without settings. return; }