Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinyin dependency not declared in setup.py #121

Open
clach04 opened this issue Aug 29, 2024 · 0 comments
Open

pinyin dependency not declared in setup.py #121

clach04 opened this issue Aug 29, 2024 · 0 comments

Comments

@clach04
Copy link

clach04 commented Aug 29, 2024

Docs make this a manual step https://github.com/mooz/percol?tab=readme-ov-file#pinyin-support

Could be made an optional requirement as done in #115 the code at runtime is already optional.
clach04 added a commit to clach04/percolator that referenced this issue Aug 31, 2024
@clach04
Fix mooz#121, tied to mooz#115 - optional pinyin install support
2de1ae9
clach04 added a commit to clach04/percolator that referenced this issue Aug 31, 2024
@clach04
Fix mooz#121, tied to mooz#115 - optional pinyin install support
acd4e84 
Allow pip install "percol[all]" to install ALL optional dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clach04