Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

[BUG] If animation finishes in a reversed state, cancel animation #51

Closed
mattgperry opened this issue Feb 8, 2022 · 4 comments
Closed
Labels
Bug Bug report

Comments

@mattgperry
Copy link
Collaborator

Currently animations implement the behaviour of committing styles when an animation finishes. They should instead cancel animations if they finish in reverse.

@mattgperry mattgperry added the Bug Bug report label Feb 8, 2022
@bakura10
Copy link
Collaborator

Hi !

I am not sure if this is related to this issue, but I think it may. I am currently having the following animation:

if (newValue === '') {
        this.apparitionTimeline = timeline([
          Do things
        ]);

        this.apparitionTimeline.play();
      } else {
        this.apparitionTimeline.playbackRate = -1.2;
        this.apparitionTimeline.play();
      }

If I reverse the animation before it has finished, then it commit the final state of the first animation rather than the reverse. Is there currently a clean way to solve this issue ? :)

@mattgperry
Copy link
Collaborator Author

I don't think so - I've got a branch somewhere where I've made a start on these reverse bugs so I'll need to revive it now DevTools is out

@bakura10
Copy link
Collaborator

Awesome, thanks for the quick follow-up :).

@mattgperry
Copy link
Collaborator Author

mattgperry commented May 30, 2022

Closing for #93 and the #38 feature request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants