You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When sending an HTTP3 datagram, we prefix it with the session id. In order to do so, we write the session ID into a new Encoder and then copy the entire datagram over into that Encoder.
This is not easily possible I think. We need ownership of the data in QuicDatagrams::add_datagram when we push it into the queue as a new QuicDatagram so we need to reallocate at some point anyways, might as well do it here while we prefix the session ID.
Maybe we could do something with lifetimes there, but I'm not experienced enough with Rust to assess if that would be at all feasible (and going by Max's "if you're using lifetimes you're probably doing something wrong" advice, probably not).
When sending an HTTP3 datagram, we prefix it with the session id. In order to do so, we write the session ID into a new
Encoder
and then copy the entire datagram over into thatEncoder
.neqo/neqo-http3/src/features/extended_connect/webtransport_session.rs
Lines 415 to 418 in 3001a3a
We might be able to do better, e.g. passing session ID and datagram down separately.
The text was updated successfully, but these errors were encountered: