Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afocal systems break focal length and platescale calculations #200

Open
douglase opened this issue Jan 3, 2017 · 0 comments
Open

afocal systems break focal length and platescale calculations #200

douglase opened this issue Jan 3, 2017 · 0 comments

Comments

@douglase
Copy link
Contributor

douglase commented Jan 3, 2017

As discovered recently by @neilzim and as previously noted but not documented, the current way plate scales are calculated in the fresnel wavefront class depends on the focal length attribute carried through the sequence of propagations by the wavefront class. Thus, it breaks when you have an afocal system where plane-to-plane propagation occurs.

We need either another way of carrying focal length through a system, or more graceful failure and better documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant