Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB14_v3 items are decoded incorrectly #142

Closed
stijn-vranckx opened this issue Jul 31, 2024 · 3 comments
Closed

RGB14_v3 items are decoded incorrectly #142

stijn-vranckx opened this issue Jul 31, 2024 · 3 comments

Comments

@stijn-vranckx
Copy link

The color values are incorrect. See #141 for a possible fix and a file to reproduce the issue.

@mreutegg
Copy link
Owner

Thank you for reporting this issue and a file to reproduce.

As you hinted already in #141, the problem seems to be caused by context being passed by value to LASreadItem.read() and LASreadItemCompressed.init().

#143 introduces a MutableInteger and uses it as type for the context parameters. With these changes the laz file available via #141 translates into a same las file as with LASTools.

@stijn-vranckx, can you please give it a try as well? I'd also like to add the laz file referenced in #141 as a test resource. What is the license for that file?

@stijn-vranckx
Copy link
Author

@mreutegg For the license:

This pointcloud was captured by Hexagon airborne sensors and processed using Hexagon's ERDAS IMAGINE software. The small LAZ chip exported can be used for software test coverage and can be considered under CC-BY since the dataset is so small.

So I think the fiel can be added as a test resource.
I gave it a try and it is also working on my site.

@mreutegg
Copy link
Owner

Thank you for testing #143. I added the file as a test resource and there is now a test using it.

The fix will be available in laszip4j 0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants