Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerify Everything #3

Open
15 of 23 tasks
msmith-techempower opened this issue Feb 6, 2018 · 0 comments
Open
15 of 23 tasks

Dockerify Everything #3

msmith-techempower opened this issue Feb 6, 2018 · 0 comments

Comments

@msmith-techempower
Copy link
Owner

msmith-techempower commented Feb 6, 2018 •
edited
Loading

Abstract

Move the suite away from the current methodology of using scripting files to handle dependencies, installation into the $IROOT directory for sandboxing, and instead use Docker CE.

Reasoning

  1. Installing software to $IROOT is hard (much harder than apt-get) and prone to difficult-to-identify errors
  2. Many dependencies use apt-get already for various reasons, and migrating away from globally installed software is hard (much harder than allowing apt-get)
  3. Docker provides a much cleaner reusable sandbox environment that has been fire-tested much more-so than our in-house implementation
  4. In testing, Docker does not appear to incur much (if any) performance penalty

Ongoing work is in this branch.

Action Items (in no particular order)

  • Create base tfb dockerfile with as minimal software installed as possible
  • Implement base dockerfile to have an entrypoint of TFBReapear so that everything is run through him
  • Create POC using only gemini and the dockerfile(s) required to build and run in console mode
  • Create POC suite implementation using the dockerfile(s) require to build and run gemini and perform a verification
  • Implement stable mechanism for finding running docker containers and stopping them
  • Implement stable mechanism for removing docker images for a specific test after the container is stopped (there is no reason to keep a gemini image after we have run the gemini test)
  • Create docker folder hierarchy that would allow for similar grouping to our current dependency hierarchy (docker/languages, docker/frameworks, etc)
  • Change benchmark_config.json to specify a dockerfile instead of a setup.sh
  • Implement database mechanisms currently handled by fw_depends (which is being deprecated and removed with the docker work)
  • Implement client mechanisms currently handled by fw_depends (installing wrk on the remote client, etc)
  • Update vagrant install to call tfb --init --quiet to initialize the software on the database and client machine (localhost)
  • Fix docker build process to split the output to the console as well as the log (see framework_test.py for an example of this; this is needed to see output in Travis-CI, for example)
  • Implement error-handling for an unfound dependency (docker build... cannot find the file referenced in FROM something in a dockerfile)
  • Implement error-handling for a docker build failing (docker build... fails for some reason)
  • Implement error-handling for a test not starting properly (docker run... fails for some reason)
  • Clean out prerequisites.sh since it will no longer require most of the packages listed (they will move to the various dockerfiles)
  • Update prerequisites.sh to install Rust and build TFBReaper
  • Update prerequisites.sh to install Docker CE
  • ... Migrate all the shell scripts to dockerfiles
  • Updated scaffolding to reflect the docker implementation (instructions, default files, etc)
  • Update documentation to reflect all these changes
  • Set ulimit on containers (see this)
  • Update --clean-all implementation to delete all docker images
msmith-techempower pushed a commit that referenced this issue Feb 16, 2018
@michaelhixson @NateBrady23
Try to fix PHP/hhvm tests by working around an issue with SET NAMES (T…
903997f 
…echEmpower#3220)

I think we are running into this problem:

  facebook/hhvm#8111

We don't solve that problem, but we avoid it by specifying utf8 in a
different fashion.  I also took the opportunity to use the "TFB-database"
hostname instead of the DBHOST environment variable because it's simpler
that way.

Here are the steps I took in a local TFB environment that make me think
we're running into the same issue as that GitHub issue:

 - Run toolset/run-tests.py --mode verify --test hvm, see that it fails
   all tests with error messages that look like the application server
   simply isn't there
 - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the
   "Log" section over from config-debug.hdf), run the test again
 - Look at the log file it spit out, PHP/hhvm/error.log, notice messages
   like this:

    Core dumped: Segmentation fault
    Stack trace in /tmp/stacktrace.28653.log

 - /tmp is cleared by the TFB toolset each run, so I comment out that
   part of benchmarker.py that clears /tmp
 - Run the test again, look at the stacktrace file in /tmp, notice a
   stack trace referring to our implementation code like this:

    #0  PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14]
    #1  Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31]
    #2  Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10]
    #3  main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13]

 - Google a bit, come across a GitHub issue talking about a similar
   problem when they used "SET NAMES"
 - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run
   test again and it worked, except for fortunes which failed because of
   character encoding problems
 - Google for a different way to specify utf8 in the PDO constructor,
   try it again, all tests pass locally
msmith-techempower pushed a commit that referenced this issue Apr 25, 2018
@michaelhixson @NateBrady23
Fix an uncaught exception during dart startup (TechEmpower#3640)
04dd98d 
Here's an example of the error output from before this change:

Unhandled exception:
Bad state: Stream was already listened to
#0      _RawServerSocket.listen (dart:io-patch/socket_patch.dart:1106)
#1      new _ForwardingStreamSubscription (dart:async/stream_pipe.dart:123)
#2      _ForwardingStream._createSubscription (dart:async/stream_pipe.dart:91)
#3      _ForwardingStream.listen (dart:async/stream_pipe.dart:86)
TechEmpower#4      _ServerSocket.listen (dart:io-patch/socket_patch.dart:1351)
TechEmpower#5      _HttpServer.listen (dart:io/http_impl.dart:2278)
TechEmpower#6      _startServer.<anonymous closure> (file:///server.dart:88:12)
TechEmpower#7      _RootZone.runUnary (dart:async/zone.dart:1371)
TechEmpower#8      _FutureListener.handleValue (dart:async/future_impl.dart:129)
TechEmpower#9      _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
TechEmpower#10     _Future._propagateToListeners (dart:async/future_impl.dart:665)
TechEmpower#11     _Future._completeWithValue (dart:async/future_impl.dart:478)
TechEmpower#12     Future.wait.<anonymous closure> (dart:async/future.dart:362)
TechEmpower#13     _RootZone.runUnary (dart:async/zone.dart:1371)
TechEmpower#14     _FutureListener.handleValue (dart:async/future_impl.dart:129)
TechEmpower#15     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
TechEmpower#16     _Future._propagateToListeners (dart:async/future_impl.dart:665)
TechEmpower#17     _Future._completeWithValue (dart:async/future_impl.dart:478)
TechEmpower#18     Future.wait.<anonymous closure> (dart:async/future.dart:362)
TechEmpower#19     _RootZone.runUnary (dart:async/zone.dart:1371)
TechEmpower#20     _FutureListener.handleValue (dart:async/future_impl.dart:129)
TechEmpower#21     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
TechEmpower#22     _Future._propagateToListeners (dart:async/future_impl.dart:665)
TechEmpower#23     _Future._completeWithValue (dart:async/future_impl.dart:478)
TechEmpower#24     _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:510)
TechEmpower#25     _microtaskLoop (dart:async/schedule_microtask.dart:41)
TechEmpower#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
TechEmpower#27     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:99)
TechEmpower#28     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:152)
msmith-techempower pushed a commit that referenced this issue Jul 18, 2023
@itrofimow
[C++] Introduce userver (TechEmpower#7617)
e20a158 
* introduce userver: + plaintext

* + json

* + db

* fix README

* lock userver version

* nproc in make -j

* some tweaks

* Userver -> userver

* + march=native

* fix paths in README

* cr from userver crew fixes

* up userver commit

* tune coroutine limits a bit

* Userver db (#3)

* add queries/updates tests

* Restructure project (TechEmpower#4)

* restructure project
* add cached-queries

* fix readme (TechEmpower#5)

* tune postgres connections pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msmith-techempower