Allow disabling websockets in profile settings #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like quite a few UK players (on BT internet provider, 33% of UK) are running into issues again where the websocket connection is getting dropped precisely every 20 seconds - this is the same behavior that was seen in summer of 2023.
Adding a setting that lets a player just disable the websocket connections completely with note that this is not recommended if otherwise working. I don't actually store this in the server as I don't think that makes sense and if someone signed in from a different machine or connection it's probably better we just assume websockets will work and require updating the setting again locally if it needs to be. This also means it will persist across different accounts on the same machine / browser session which is also probably preferable.