Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop-up window behavior #7

Open
msasena opened this issue Mar 20, 2013 · 1 comment
Open

pop-up window behavior #7

msasena opened this issue Mar 20, 2013 · 1 comment

Comments

@msasena
Copy link

msasena commented Mar 20, 2013

I would recommend a change to the way you toggle on / off the pop-up windows. At present, clicking on an icon opens a pop-up window with more informationfor that particular language element. Clicking on it again closes that particular pop-up window.

I would find it more natural that clicking on an icon brings up the window, and clicking anywhere else on the window hides it again. Likewise, clicking on a different link opens the new window, thereby closing the first. That is, there should only ever be 0 or 1 pop-up windows displayed at any given time. So you either click on an icon to show that feature's information, or you click anywhere else to hide all pop-up windows.

@xogeny
Copy link
Collaborator

xogeny commented Mar 20, 2013

I admit this is an issue. However, please not that I have already set things up so that the Escape key will close everything.

I have researched both the idea that each new popup should close the others and that clicking outside the popup closes it. In fact, somebody else came up with a really slick extension to Bootstrap called BootstrapX Clickovers. Unfortunately, they don't seem to work with modern versions of Bootstrap which is really sad because they do everything you asked for and more.

For now, the Escape key (which is documented in the lower-left corner, BTW) is all I have. Anybody who wants to spend some time hacking on the jQuery/Javascript code required is more than welcome to try. I may very well give it another go soon. The key file is js/popovers.js and you'll see how the bindings for Escape were already implemented.

@ghost ghost assigned xogeny and mtiller Mar 20, 2013
mtiller added a commit that referenced this issue Mar 21, 2013
This is in response to issue #7.  This is an incremental improvement.
I suspect there is more I can do, but this should make use of the
reference material on a tablet a little bit easier and perhaps
even for desktop users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants