-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Due to time zone issues, the e2e test cannot be passed #641
Comments
Thanks for reporting this! Can you try #644 to see if it fixes it? |
Oh, good catch! Can you submit a PR that confirms your hypothesis? |
Of course! |
DmitroProciv
pushed a commit
to DmitroProciv/picoshare
that referenced
this issue
Jan 4, 2025
Resolves mtlynch/picoshare#641 Related PR: mtlynch/picoshare#644 The above PR has largely addressed the corresponding issue, but there is one missing part. This PR completes the missing part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When I select a custom expiration time and choose "A day", it returns "A-1 day".
Some of the end-to-end tests set a custom expiration and then check its value.
For example:
This is causing issues with passing some end-to-end tests.
Possible Reason
I believe this may be related to timezone issues. I am located in the UTC+8 timezone. I noticed that the
formatDate
function, which is intended to return an ISO date, might be the cause:Screenshots
Environment
However, I don't believe this is an environment issue, as the code I didn't modify also triggers errors on the CircleCI platform.

The text was updated successfully, but these errors were encountered: