Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use custom Router provider #42

Open
trinvh opened this issue Apr 18, 2020 · 1 comment
Open

Ability to use custom Router provider #42

trinvh opened this issue Apr 18, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers priority Issue should be prioritized

Comments

@trinvh
Copy link

trinvh commented Apr 18, 2020

Currently this package get all routes by calling default laravel router. Please add an ability to use custom class to get routes.

Typically we will need a new config that pass the default class to fetch all routes:

Currently:

$routes = app('Dingo\Api\Routing\Router')->getRoutes();

In this case I'm using package dingo/api so it should look like this:

$routes = [];
foreach(app('Dingo\Api\Routing\Router')->getRoutes() as $r) {
    foreach($r->getRoutes() as $rr) {
        $routes[] = $rr;
    }
}

Anw, I believe this package would be a must-have package in future. Thanks so much for your efforts!

@mtrajano mtrajano added enhancement New feature or request good first issue Good for newcomers priority Issue should be prioritized labels Apr 20, 2020
@mtrajano
Copy link
Owner

Seems like a lot of people from the laravel community depend on this package. I'll prioritize this issue right after I'm doing pushing a stable release of the 0.7 branch. I've been doing some major clean up and testing in that branch and would like to get that out first. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority Issue should be prioritized
Projects
None yet
Development

No branches or pull requests

2 participants